Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Isolate logic that distributes Components output after run #7845

Merged
merged 13 commits into from
Jun 14, 2024

Conversation

silvanocerza
Copy link
Contributor

Related Issues

Proposed Changes:

Isolate logic that distributes Components output after run.

This also slightly changes the _run_component() method to resetting variadics as it was done in the wrong place.

How did you test it?

I added tests and ran them locally.

Notes for the reviewer

N/A

Checklist

@silvanocerza silvanocerza added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Jun 11, 2024
@silvanocerza silvanocerza self-assigned this Jun 11, 2024
@silvanocerza silvanocerza requested a review from a team as a code owner June 11, 2024 15:41
@silvanocerza silvanocerza requested review from davidsbatista and removed request for a team and davidsbatista June 11, 2024 15:41
@coveralls
Copy link
Collaborator

coveralls commented Jun 11, 2024

Pull Request Test Coverage Report for Build 9468686654

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 43 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 89.927%

Files with Coverage Reduction New Missed Lines %
core/pipeline/pipeline.py 43 72.13%
Totals Coverage Status
Change from base Build 9467243080: 0.1%
Covered Lines: 6874
Relevant Lines: 7644

💛 - Coveralls

Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move those methods to the base class?

@coveralls
Copy link
Collaborator

coveralls commented Jun 12, 2024

Pull Request Test Coverage Report for Build 9485718095

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 38 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.08%) to 89.892%

Files with Coverage Reduction New Missed Lines %
core/pipeline/base.py 6 92.76%
core/pipeline/pipeline.py 32 68.31%
Totals Coverage Status
Change from base Build 9467243080: 0.08%
Covered Lines: 6928
Relevant Lines: 7707

💛 - Coveralls

Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

haystack/core/pipeline/base.py Show resolved Hide resolved
haystack/core/pipeline/base.py Outdated Show resolved Hide resolved
haystack/core/pipeline/base.py Outdated Show resolved Hide resolved
haystack/core/pipeline/base.py Show resolved Hide resolved
haystack/core/pipeline/base.py Outdated Show resolved Hide resolved
haystack/core/pipeline/base.py Outdated Show resolved Hide resolved
haystack/core/pipeline/base.py Show resolved Hide resolved
haystack/core/pipeline/base.py Outdated Show resolved Hide resolved
@coveralls
Copy link
Collaborator

coveralls commented Jun 13, 2024

Pull Request Test Coverage Report for Build 9501066047

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 39 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.08%) to 89.738%

Files with Coverage Reduction New Missed Lines %
core/pipeline/base.py 7 92.5%
core/pipeline/pipeline.py 32 68.31%
Totals Coverage Status
Change from base Build 9467243080: -0.08%
Covered Lines: 6917
Relevant Lines: 7708

💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 14, 2024

Pull Request Test Coverage Report for Build 9514060310

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 38 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 89.75%

Files with Coverage Reduction New Missed Lines %
core/pipeline/base.py 6 92.76%
core/pipeline/pipeline.py 32 68.31%
Totals Coverage Status
Change from base Build 9467243080: -0.07%
Covered Lines: 6917
Relevant Lines: 7707

💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 14, 2024

Pull Request Test Coverage Report for Build 9514365962

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 39 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.08%) to 89.738%

Files with Coverage Reduction New Missed Lines %
core/pipeline/base.py 7 92.5%
core/pipeline/pipeline.py 32 68.31%
Totals Coverage Status
Change from base Build 9467243080: -0.08%
Covered Lines: 6917
Relevant Lines: 7708

💛 - Coveralls

@silvanocerza silvanocerza merged commit 1b4bd17 into main Jun 14, 2024
19 checks passed
@silvanocerza silvanocerza deleted the pipeline-run-refactor branch June 14, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:core topic:tests type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants