Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Isolate code that runs single Pipeline Component #7837

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

silvanocerza
Copy link
Contributor

Related Issues

Part of #7614

Proposed Changes:

Isolate code that runs single Pipeline Component

How did you test it?

I added a new unit test and ran test locally.

Notes for the reviewer

I had to update some tracing tests as the tracing data was wrong.

Checklist

@silvanocerza silvanocerza added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Jun 10, 2024
@silvanocerza silvanocerza self-assigned this Jun 10, 2024
@silvanocerza silvanocerza requested a review from a team as a code owner June 10, 2024 15:31
@silvanocerza silvanocerza requested review from davidsbatista and removed request for a team June 10, 2024 15:31
@coveralls
Copy link
Collaborator

coveralls commented Jun 10, 2024

Pull Request Test Coverage Report for Build 9451238192

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 46 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.005%) to 89.803%

Files with Coverage Reduction New Missed Lines %
core/pipeline/pipeline.py 46 63.52%
Totals Coverage Status
Change from base Build 9448706661: 0.005%
Covered Lines: 6843
Relevant Lines: 7620

💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 10, 2024

Pull Request Test Coverage Report for Build 9451398780

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 46 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.005%) to 89.803%

Files with Coverage Reduction New Missed Lines %
core/pipeline/pipeline.py 46 63.52%
Totals Coverage Status
Change from base Build 9448706661: 0.005%
Covered Lines: 6843
Relevant Lines: 7620

💛 - Coveralls

@silvanocerza silvanocerza enabled auto-merge (squash) June 10, 2024 15:50
@silvanocerza silvanocerza merged commit 58dd972 into main Jun 10, 2024
19 checks passed
@silvanocerza silvanocerza deleted the pipeline-run-refactor branch June 10, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:core topic:tests type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants