Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade transformers test dependency #7815

Merged
merged 1 commit into from
Jun 6, 2024
Merged

chore: upgrade transformers test dependency #7815

merged 1 commit into from
Jun 6, 2024

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Jun 6, 2024 •
edited
Loading

Proposed Changes:

  • upgrade transformers to the latest stable version (released a week ago)
  • reorganize a bit the test dependencies

How did you test it?

CI

Checklist

@anakin87 anakin87 added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Jun 6, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jun 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9398596793

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.732%
Totals Coverage Status
Change from base Build 9387490162: 0.0%
Covered Lines: 6773
Relevant Lines: 7548
💛 - Coveralls

@anakin87 anakin87 marked this pull request as ready for review June 6, 2024 10:00
@anakin87 anakin87 requested a review from a team as a code owner June 6, 2024 10:00
@anakin87 anakin87 requested review from Amnah199 and silvanocerza and removed request for a team June 6, 2024 10:00
@coveralls
Copy link
Collaborator

coveralls commented Jun 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9398899378

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.732%
Totals Coverage Status
Change from base Build 9387490162: 0.0%
Covered Lines: 6773
Relevant Lines: 7548
💛 - Coveralls

silvanocerza
silvanocerza approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@silvanocerza silvanocerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing, that's good for me. 👍

@anakin87 anakin87 merged commit bde92fd into main Jun 6, 2024
30 of 31 checks passed
@anakin87 anakin87 deleted the upgrade-transformers branch June 6, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

@Amnah199 Amnah199 Awaiting requested review from Amnah199 Amnah199 is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:build/distribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anakin87 @coveralls @silvanocerza