Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace mistral-7b with zephyr-7b-beta in tests #7576

Merged
merged 3 commits into from
Apr 23, 2024
Merged

test: replace mistral-7b with zephyr-7b-beta in tests #7576

merged 3 commits into from
Apr 23, 2024

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Apr 23, 2024 •
edited
Loading

Related Issues

Proposed Changes:

Replace mistralai/Mistral-7B-v0.1 with HuggingFaceH4/zephyr-7b-beta in HuggingFaceAPIGenerator tests.

  • not a gated repo
  • Mistral models on HF have been quite unstable lately (about access, etc.)
  • (Mistral-7B-v0.1 is a base model, so it is not appropriate for practical use cases)

How did you test it?

CI

Checklist

@github-actions github-actions bot added topic:tests 2.x Related to Haystack v2.0 type:documentation Improvements on the docs labels Apr 23, 2024
@anakin87 anakin87 changed the title replace mistral-7b with gemma-2b-it in tests test: replace mistral-7b with gemma-2b-it in tests Apr 23, 2024
@anakin87 anakin87 added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Apr 23, 2024
anakin87
anakin87 commented Apr 23, 2024
View reviewed changes
test/components/generators/test_hugging_face_api.py
def test_generate_text_with_streaming_callback(
self, mock_check_valid_model, mock_auto_tokenizer, mock_text_generation
):
def test_generate_text_with_streaming_callback(self, mock_check_valid_model, mock_text_generation):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated

@coveralls
Copy link
Collaborator

coveralls commented Apr 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8798246946

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.106%
Totals Coverage Status
Change from base Build 8784359146: 0.0%
Covered Lines: 6284
Relevant Lines: 6974
💛 - Coveralls

@anakin87 anakin87 changed the title test: replace mistral-7b with gemma-2b-it in tests test: replace mistral-7b with zephyr-7b-beta in tests Apr 23, 2024
@anakin87 anakin87 marked this pull request as ready for review April 23, 2024 09:40
@anakin87 anakin87 requested a review from a team as a code owner April 23, 2024 09:40
@anakin87 anakin87 requested review from davidsbatista and removed request for a team April 23, 2024 09:40
davidsbatista
davidsbatista approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@davidsbatista davidsbatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anakin87 anakin87 merged commit 081757c into main Apr 23, 2024
32 checks passed
@anakin87 anakin87 deleted the fix-hf-api-tests branch April 23, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsbatista davidsbatista davidsbatista approved these changes

Assignees
No one assigned
Labels
2.x Related to Haystack v2.0 ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:tests type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anakin87 @coveralls @davidsbatista