Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some more docstring fixes #7524

Merged
merged 1 commit into from
Apr 10, 2024
Merged

some more docstring fixes #7524

merged 1 commit into from
Apr 10, 2024

Conversation

davidsbatista
Copy link
Contributor

Related Issues

  • some more docstring fixes to pass the ruff linting

@davidsbatista davidsbatista requested a review from a team as a code owner April 10, 2024 07:39
@davidsbatista davidsbatista requested review from anakin87 and removed request for a team April 10, 2024 07:39
@github-actions github-actions bot added 2.x Related to Haystack v2.0 type:documentation Improvements on the docs labels Apr 10, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8627686993

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 89.816%
Files with Coverage Reduction New Missed Lines %
telemetry/_telemetry.py 4 84.15%
Totals Coverage Status
Change from base Build 8627265504: 0.0%
Covered Lines: 6165
Relevant Lines: 6864
💛 - Coveralls

@anakin87 anakin87 added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Apr 10, 2024
anakin87
anakin87 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@davidsbatista davidsbatista enabled auto-merge (squash) April 10, 2024 08:04
@davidsbatista davidsbatista merged commit 932213e into main Apr 10, 2024
21 of 22 checks passed
@davidsbatista davidsbatista deleted the fixing-some-more-docstrings branch April 10, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anakin87 anakin87 anakin87 approved these changes

Assignees
No one assigned
Labels
2.x Related to Haystack v2.0 ignore-for-release-notes PRs with this flag won't be included in the release notes. type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidsbatista @coveralls @anakin87