Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AzureOCRDocumentConverter - forward declaration of AnalyzeResult types #7523

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

anakin87
Copy link
Member

Related Issues

Proposed Changes:

Forward declaration of AnalyzeResult type in AzureOCRDocumentConverter.

AnalyzeResult is already imported in a lazy import block.
The forward declaration avoids issues when azure-ai-formrecognizer>=3.2.0b2 is not installed.

How did you test it?

CI.
Tried to run Unstructured core-integration tests with this fix. ✔️

Checklist

@anakin87 anakin87 requested review from a team as code owners April 10, 2024 06:29
@anakin87 anakin87 requested review from dfokina and shadeMe and removed request for a team April 10, 2024 06:29
@github-actions github-actions bot added the 2.x Related to Haystack v2.0 label Apr 10, 2024
@anakin87 anakin87 requested a review from vblagoje April 10, 2024 06:33
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@anakin87 anakin87 merged commit 843376b into main Apr 10, 2024
24 checks passed
@anakin87 anakin87 deleted the fix-analyze-result branch April 10, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants