Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix release notes generation on github_release workflow #7515

Merged
merged 1 commit into from
Apr 9, 2024
Merged

ci: fix release notes generation on github_release workflow #7515

merged 1 commit into from
Apr 9, 2024

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Apr 9, 2024

Related Issues

Proposed Changes:

  • trigger on the right tag
  • make it properly run both on minor releases (X.Y.0) and bugfix releases (X.Y.Z; Z!=0)

How did you test it?

  • used to release 2.0.1 on v2.0.x branch

Checklist

@github-actions github-actions bot added topic:CI 2.x Related to Haystack v2.0 labels Apr 9, 2024
@anakin87 anakin87 requested a review from masci April 9, 2024 12:43
@anakin87 anakin87 marked this pull request as ready for review April 9, 2024 12:43
@anakin87 anakin87 requested a review from a team as a code owner April 9, 2024 12:43
@anakin87 anakin87 requested review from silvanocerza and removed request for a team and silvanocerza April 9, 2024 12:43
masci
masci approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anakin87 anakin87 merged commit f5719ed into main Apr 9, 2024
11 checks passed
@anakin87 anakin87 deleted the fix-release-notes-generation-on-github-release-workflow branch April 9, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masci masci masci approved these changes

Assignees
No one assigned
Labels
2.x Related to Haystack v2.0 topic:CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make 2.x release process automatic
2 participants
@anakin87 @masci