refactor!: make TGI generators compatible with huggingface_hub>=0.22.0
#7425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:documentation
anakin87
commented
Mar 26, 2024
anakin87
commented
Mar 26, 2024
| @@ -261,7 +265,7 @@ def _run_streaming( | |||
| message = ChatMessage.from_assistant(chunk.generated_text) | |||
| message.meta.update( | |||
| { | |||
| "finish_reason": chunk.details.finish_reason.value, | |||
| "finish_reason": chunk.details.finish_reason, | |||
There was a problem hiding this comment.
finish_reason became a Literal[str]
anakin87
requested review from
dfokina and
silvanocerza
and removed request for
a team
|
@silvanocerza do you want me to review this one? I'd love to |
Pull Request Test Coverage Report for Build 8435759942Details
💛 - Coveralls |
|
@vblagoje feel free to review this PR! |
vblagoje
approved these changes
Mar 26, 2024
| TextGenerationOutput, | ||
| TextGenerationOutputToken, | ||
| TextGenerationStreamOutput, | ||
| ) |
There was a problem hiding this comment.
Niceee, they externalised these classes...
1 task
silvanocerza
pushed a commit
that referenced
this pull request
Apr 8, 2024
….0` (#7425) * progress * progress * better lazy imports * fixes * reno
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
huggingface_hub: they are now public (and less susceptible to breaking changes, I hope)huggingface_hub>=0.22.0in lazy_import message and release note. Since it is not a core dependency, there seems to be no effective way to make this encouragement mandatory.How did you test it?
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.