Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: pin huggingface_hub in tests dependencies #7417

Merged
merged 2 commits into from
Mar 25, 2024
Merged

ci: pin huggingface_hub in tests dependencies #7417

merged 2 commits into from
Mar 25, 2024

Conversation

anakin87
Copy link
Member

Related Issues

This is a test dependency.
Pinning it temporarily to avoid CI failures due to the 0.22.0 release: https://github.com/deepset-ai/haystack/actions/runs/8422628045/job/23062679697?pr=7362

@anakin87 anakin87 added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Mar 25, 2024
@anakin87 anakin87 requested a review from a team as a code owner March 25, 2024 17:14
@anakin87 anakin87 requested review from masci and removed request for a team March 25, 2024 17:14
@github-actions github-actions bot added topic:build/distribution 2.x Related to Haystack v2.0 labels Mar 25, 2024
@coveralls
Copy link
Collaborator

coveralls commented Mar 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8424183444

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.401%
Totals Coverage Status
Change from base Build 8418801189: 0.0%
Covered Lines: 5491
Relevant Lines: 6142
💛 - Coveralls

@anakin87 anakin87 merged commit 19d3f39 into main Mar 25, 2024
39 checks passed
@anakin87 anakin87 deleted the pin-huggingface-hub-test-deps branch March 25, 2024 17:52
@anakin87 anakin87 mentioned this pull request Apr 6, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

@masci masci Awaiting requested review from masci masci is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
2.x Related to Haystack v2.0 ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:build/distribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anakin87 @coveralls @silvanocerza