Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add the @component decorator to HuggingFaceTGIChatGenerator #7396

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

anakin87
Copy link
Member

Related Issues

Proposed Changes:

Add the @component decorator to HuggingFaceTGIChatGenerator.
The lack of this decorator made it impossible to use the HuggingFaceTGIChatGenerator in a pipeline.

How did you test it?

CI

Checklist

@anakin87 anakin87 requested review from a team as code owners March 21, 2024 08:00
@anakin87 anakin87 requested review from dfokina and julian-risch and removed request for a team March 21, 2024 08:00
@github-actions github-actions bot added the 2.x Related to Haystack v2.0 label Mar 21, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8371499537

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 89.263%

Files with Coverage Reduction New Missed Lines %
components/generators/chat/hugging_face_tgi.py 5 94.79%
Totals Coverage Status
Change from base Build 8362383368: 0.002%
Covered Lines: 5412
Relevant Lines: 6063

💛 - Coveralls

@anakin87 anakin87 merged commit b0a9508 into main Mar 21, 2024
24 checks passed
@anakin87 anakin87 deleted the tgi-chat-missing-comp-decorator branch March 21, 2024 08:28
@anakin87 anakin87 added this to the 2.0.1 milestone Mar 21, 2024
silvanocerza pushed a commit that referenced this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HuggingFaceTGIChatGenerator does not work properly in a Pipeline
3 participants