feat: introduce SparseEmbedding
#7382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic:tests
2.x
anakin87
commented
Mar 19, 2024
| @@ -114,7 +119,8 @@ def _create_id(self): | |||
| mime_type = self.blob.mime_type if self.blob is not None else None | |||
| meta = self.meta or {} | |||
| embedding = self.embedding if self.embedding is not None else None | |||
| data = f"{text}{dataframe}{blob}{mime_type}{meta}{embedding}" | |||
| sparse_embedding = self.sparse_embedding.to_dict() if self.sparse_embedding is not None else "" | |||
There was a problem hiding this comment.
This differs a bit from the other ones to not alter the id of existing Documents.
I can change it if you think it's better.
There was a problem hiding this comment.
Good catch! This approach looks good to me 👍
Pull Request Test Coverage Report for Build 8345165529Details
💛 - Coveralls |
anakin87
requested review from
dfokina,
davidsbatista,
masci and
silvanocerza
and removed request for
a team and
davidsbatista
masci
approved these changes
Mar 19, 2024
| @@ -114,7 +119,8 @@ def _create_id(self): | |||
| mime_type = self.blob.mime_type if self.blob is not None else None | |||
| meta = self.meta or {} | |||
| embedding = self.embedding if self.embedding is not None else None | |||
| data = f"{text}{dataframe}{blob}{mime_type}{meta}{embedding}" | |||
| sparse_embedding = self.sparse_embedding.to_dict() if self.sparse_embedding is not None else "" | |||
There was a problem hiding this comment.
Good catch! This approach looks good to me 👍
silvanocerza
approved these changes
Mar 19, 2024
This was referenced Mar 20, 2024
Merged
silvanocerza
pushed a commit
that referenced
this pull request
Apr 8, 2024
* introduce SparseEmbedding * reno * add to pydoc config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Introduce a new class to store sparse embeddings.
Contains two fields:
indicesandvalues, which must have the same length.How did you test it?
New unit tests, change some existing tests, CI.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.