Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unpin OpenAI and fix problem with mock #7364

Merged
merged 1 commit into from
Mar 15, 2024
Merged

fix: unpin OpenAI and fix problem with mock #7364

merged 1 commit into from
Mar 15, 2024

Conversation

anakin87
Copy link
Member

Related Issues

Starting from openai==1.14.0, Stream invokes a method of the client.
This made our test fail since our client was null.

Proposed Changes:

Change the MockStream in tests to make it use a mock of the client.

How did you test it?

CI.
Manual tests with openai==1.14.0 and openai==1.1.0

Checklist

@anakin87 anakin87 added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Mar 14, 2024
@anakin87 anakin87 requested a review from a team as a code owner March 14, 2024 17:17
@anakin87 anakin87 requested review from vblagoje and removed request for a team March 14, 2024 17:17
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8284910414

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.164%
Totals Coverage Status
Change from base Build 8278967162: 0.0%
Covered Lines: 5324
Relevant Lines: 5971
💛 - Coveralls

@vblagoje
Copy link
Member

Man, amazing! Thank you 🙏

vblagoje
vblagoje approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@vblagoje vblagoje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go 🚀

@anakin87 anakin87 merged commit abda78c into main Mar 15, 2024
24 checks passed
@anakin87 anakin87 deleted the fix-openai-mock branch March 15, 2024 07:32
@silvanocerza silvanocerza added this to the 2.0.1 milestone Apr 8, 2024
silvanocerza pushed a commit that referenced this pull request Apr 8, 2024
@anakin87 @silvanocerza
unpin OpenAI and fix problem with mock (#7364)
f112034
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vblagoje vblagoje vblagoje approved these changes

Assignees
No one assigned
Labels
2.x Related to Haystack v2.0 ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:build/distribution topic:tests
Projects
None yet
Milestone
2.0.1
Development

Successfully merging this pull request may close these issues.

bug: Latest openai library breaks some unit tests
4 participants
@anakin87 @coveralls @vblagoje @silvanocerza