Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade transformers to 4.38.2 in test environment #7363

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

anakin87
Copy link
Member

Proposed Changes:

Transformers 4.38.2 was released 2 weeks ago and should be stable.
As usual, we are updating the dependency in the test environment
to ensure we are still compatible.

How did you test it?

CI

Checklist

@anakin87 anakin87 added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Mar 14, 2024
@anakin87 anakin87 requested a review from a team as a code owner March 14, 2024 16:43
@anakin87 anakin87 requested review from davidsbatista and removed request for a team March 14, 2024 16:43
@github-actions github-actions bot added topic:build/distribution 2.x Related to Haystack v2.0 labels Mar 14, 2024
@@ -19,6 +19,7 @@ on:
- "haystack/**/*.py"
- "haystack/core/pipeline/predefined/*"
- "test/**/*.py"
- "pyproject.toml"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated: pyproject should be here

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8284488779

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.164%

Totals Coverage Status
Change from base Build 8278967162: 0.0%
Covered Lines: 5324
Relevant Lines: 5971

💛 - Coveralls

Copy link
Contributor

@davidsbatista davidsbatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anakin87 anakin87 merged commit e793c71 into main Mar 15, 2024
23 checks passed
@anakin87 anakin87 deleted the update-transformers-4-38-2 branch March 15, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0 ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:build/distribution topic:CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants