fix: fix output types in WebSearch components #7274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anakin87
added
the
ignore-for-release-notes
Pull Request Test Coverage Report for Build 8100514844Details
💛 - Coveralls |
shadeMe
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
LinkContentFetcher#7273Proposed Changes:
Restrict the output type of links to
List[str]: this makes it possible to connect WebSearch components to theLinkContentFetcher.How did you test it?
Manual test; CI.
(Maybe in the future, we should also add an e2e test for a Web RAG Pipeline)
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.