Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: review Preprocessors docstrings #7219

Merged
merged 1 commit into from
Feb 27, 2024
Merged

docs: review Preprocessors docstrings #7219

merged 1 commit into from
Feb 27, 2024

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 requested a review from a team as a code owner February 27, 2024 12:25
@anakin87 anakin87 requested review from silvanocerza and removed request for a team February 27, 2024 12:25
@github-actions github-actions bot added 2.x Related to Haystack v2.0 type:documentation Improvements on the docs labels Feb 27, 2024
@anakin87 anakin87 added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Feb 27, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8064676114

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 89.971%
Files with Coverage Reduction New Missed Lines %
components/preprocessors/document_cleaner.py 1 98.82%
components/preprocessors/document_splitter.py 1 98.11%
Totals Coverage Status
Change from base Build 8062197492: 0.0%
Covered Lines: 5257
Relevant Lines: 5843
💛 - Coveralls

@anakin87 anakin87 merged commit 9b1d792 into main Feb 27, 2024
26 of 27 checks passed
@anakin87 anakin87 deleted the preprocessors-docstrings branch February 27, 2024 14:51
@anakin87 anakin87 mentioned this pull request Feb 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

Assignees
No one assigned
Labels
2.x Related to Haystack v2.0 ignore-for-release-notes PRs with this flag won't be included in the release notes. type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API Docs - haystack.components.preprocessors Docstrings - haystack.components.preprocessors
3 participants
@anakin87 @coveralls @silvanocerza