Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restore transparent background for Pipeline images #7086

Merged
merged 1 commit into from
Feb 26, 2024
Merged

fix: restore transparent background for Pipeline images #7086

merged 1 commit into from
Feb 26, 2024

Conversation

anakin87
Copy link
Member

Related Issues

Proposed Changes:

Simply force the image to be a PNG:
this makes the background transparent (jihchi/mermaid.ink#130).

How did you test it?

Checklist

@anakin87 anakin87 requested review from a team as code owners February 24, 2024 11:59
@anakin87 anakin87 requested review from dfokina and vblagoje and removed request for a team February 24, 2024 11:59
@github-actions github-actions bot added 2.x Related to Haystack v2.0 topic:core labels Feb 24, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8030344823

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.878%
Totals Coverage Status
Change from base Build 8021762558: 0.0%
Covered Lines: 5212
Relevant Lines: 5799
💛 - Coveralls

vblagoje
vblagoje approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@vblagoje vblagoje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@anakin87 anakin87 merged commit 3b8af36 into main Feb 26, 2024
22 checks passed
@anakin87 anakin87 deleted the pipe-draw-transparent-bg branch February 26, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vblagoje vblagoje vblagoje approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

Assignees
No one assigned
Labels
2.x Related to Haystack v2.0 topic:core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pipeline drawings in Colab have black background
3 participants
@anakin87 @coveralls @vblagoje