Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: only only skip tests if no code changes at all #7061

Merged
merged 5 commits into from
Feb 22, 2024
Merged

Conversation

wochinge
Copy link
Contributor

Related Issues

  • fixes #issue-number

Proposed Changes:

  • previously the CI skipped the tests if there was at least one no code change (which is quite normal since you usually add release notes)
    • GH docs on paths-ignore filter

      If any path names do not match patterns in paths-ignore, even if some path names match the patterns, the workflow will run.

  • this now adds a separate filter to ensure that there is really no code change

How did you test it?

  • manual as part of this PR

Notes for the reviewer

Checklist

@github-actions github-actions bot added topic:CI 2.x Related to Haystack v2.0 labels Feb 22, 2024
@wochinge
Copy link
Contributor Author

No code change: Correctly skipped

Screenshot 2024-02-22 at 10 55 32

@wochinge wochinge marked this pull request as ready for review February 22, 2024 10:06
@wochinge wochinge requested a review from a team as a code owner February 22, 2024 10:06
@wochinge wochinge requested review from ZanSara and removed request for a team February 22, 2024 10:06
@wochinge
Copy link
Contributor Author

Skipping if code change

Screenshot 2024-02-22 at 11 05 51

@wochinge
Copy link
Contributor Author

And again: the no code change case

Screenshot 2024-02-22 at 11 08 01

@coveralls
Copy link
Collaborator

coveralls commented Feb 22, 2024

Pull Request Test Coverage Report for Build 8002718530

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 15 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 89.768%

Files with Coverage Reduction New Missed Lines %
core/pipeline/pipeline.py 15 94.6%
Totals Coverage Status
Change from base Build 8002496065: 0.0%
Covered Lines: 5027
Relevant Lines: 5600

💛 - Coveralls

Copy link
Contributor

@silvanocerza silvanocerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀

@silvanocerza silvanocerza merged commit d6ef2b5 into main Feb 22, 2024
7 checks passed
@silvanocerza silvanocerza deleted the ci/fix-catch-all branch February 22, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0 topic:CI topic:core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants