Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Sentence Transformers Embedders - new devices mgmt #7033

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

anakin87
Copy link
Member

Related Issues

Proposed Changes:

  • I refactored the Embedders according to the new management of devices.
  • no need to change the (Sentence Transformers) backend.

How did you test it?

CI, new tests

Checklist

@anakin87 anakin87 requested review from a team as code owners February 19, 2024 10:27
@anakin87 anakin87 requested review from dfokina and vblagoje and removed request for a team February 19, 2024 10:27
@github-actions github-actions bot added topic:tests 2.x Related to Haystack v2.0 type:documentation Improvements on the docs labels Feb 19, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7958080453

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.08%) to 89.303%

Files with Coverage Reduction New Missed Lines %
components/embedders/sentence_transformers_document_embedder.py 2 95.56%
components/embedders/sentence_transformers_text_embedder.py 2 94.59%
Totals Coverage Status
Change from base Build 7957045453: 0.08%
Covered Lines: 4984
Relevant Lines: 5581

💛 - Coveralls

Copy link
Member

@vblagoje vblagoje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@anakin87 anakin87 merged commit d00f171 into main Feb 19, 2024
23 checks passed
@anakin87 anakin87 deleted the sentence-transformers-device-mgmt branch February 19, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0 topic:tests type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants