Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: specify CPU device in warm_up test #7014

Merged
merged 1 commit into from
Feb 16, 2024
Merged

fix: specify CPU device in warm_up test #7014

merged 1 commit into from
Feb 16, 2024

Conversation

anakin87
Copy link
Member

This test fails if the default device is not CPU.

Now I am explicitly initializing the component with CPU device.

@anakin87 anakin87 added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Feb 16, 2024
@anakin87 anakin87 requested a review from a team as a code owner February 16, 2024 11:32
@anakin87 anakin87 requested review from ZanSara and removed request for a team and ZanSara February 16, 2024 11:32
@github-actions github-actions bot added topic:tests 2.x Related to Haystack v2.0 labels Feb 16, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7929957468

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.211%
Totals Coverage Status
Change from base Build 7929233290: 0.0%
Covered Lines: 4961
Relevant Lines: 5561
💛 - Coveralls

@anakin87 anakin87 merged commit 44b5ae2 into main Feb 16, 2024
21 checks passed
@anakin87 anakin87 deleted the fix-whisper-test-cpu branch February 16, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

Assignees
No one assigned
Labels
2.x Related to Haystack v2.0 ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anakin87 @coveralls @silvanocerza