Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: LocalWhisperTranscriber - new devices mgmt #7008

Merged
merged 4 commits into from
Feb 16, 2024

Conversation

anakin87
Copy link
Member

Related Issues

Proposed Changes:

How did you test it?

Notes for the reviewer

Checklist

@github-actions github-actions bot added topic:tests 2.x Related to Haystack v2.0 type:documentation Improvements on the docs labels Feb 15, 2024
@coveralls
Copy link
Collaborator

coveralls commented Feb 15, 2024

Pull Request Test Coverage Report for Build 7927590769

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 89.211%

Files with Coverage Reduction New Missed Lines %
components/audio/whisper_local.py 6 91.3%
Totals Coverage Status
Change from base Build 7919402243: 0.01%
Covered Lines: 4961
Relevant Lines: 5561

💛 - Coveralls

"Run 'pip install transformers[torch]' to install torch and "
"'pip install \"openai-whisper>=20231106\"' to install whisper."
) as whisper_import:
import torch
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anakin87 anakin87 marked this pull request as ready for review February 16, 2024 07:51
@anakin87 anakin87 requested review from a team as code owners February 16, 2024 07:51
@anakin87 anakin87 requested review from dfokina and shadeMe and removed request for a team February 16, 2024 07:51
@anakin87 anakin87 self-assigned this Feb 16, 2024
@anakin87 anakin87 changed the title LocalWhisperTranscriber: new devices mgmt refactor!: LocalWhisperTranscriber - new devices mgmt Feb 16, 2024
@anakin87 anakin87 merged commit 0aa788f into main Feb 16, 2024
36 checks passed
@anakin87 anakin87 deleted the whisper-loc-new-devices branch February 16, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0 topic:tests type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants