Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Clean eval components #7005

Merged
merged 2 commits into from
Feb 15, 2024
Merged

refactor: Clean eval components #7005

merged 2 commits into from
Feb 15, 2024

Conversation

silvanocerza
Copy link
Contributor

Related Issues

Proposed Changes:

Rename eval Components to evaluators and remove preprocess.py as it's not used anymore.

How did you test it?

I ran unit tests locally.

Notes for the reviewer

N/A

Checklist

@silvanocerza silvanocerza added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Feb 15, 2024
@silvanocerza silvanocerza self-assigned this Feb 15, 2024
@silvanocerza silvanocerza requested a review from a team as a code owner February 15, 2024 15:52
@silvanocerza silvanocerza requested review from julian-risch and removed request for a team February 15, 2024 15:52
@github-actions github-actions bot added topic:tests 2.x Related to Haystack v2.0 type:documentation Improvements on the docs labels Feb 15, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7918636648

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 89.199%
Totals Coverage Status
Change from base Build 7918569109: -0.03%
Covered Lines: 4955
Relevant Lines: 5555
💛 - Coveralls

@silvanocerza silvanocerza merged commit 6fe1d3b into main Feb 15, 2024
22 checks passed
@silvanocerza silvanocerza deleted the clean-eval-components branch February 15, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadeMe shadeMe shadeMe approved these changes

@julian-risch julian-risch Awaiting requested review from julian-risch julian-risch is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees

@silvanocerza silvanocerza

Labels
2.x Related to Haystack v2.0 ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:tests type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silvanocerza @coveralls @shadeMe