Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactor StatisticalEvaluator #6999

Merged
merged 4 commits into from
Feb 15, 2024
Merged

Conversation

silvanocerza
Copy link
Contributor

Related Issues

Proposed Changes:

Remove preprocessing in StatisticalEvaluator as we're going to use the TextCleaner component from #6997.

Move labels from __init__ to run.

How did you test it?

I updated unit tests.

Notes for the reviewer

This stems from feedback received in PR #6980.

Checklist

@silvanocerza silvanocerza added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Feb 15, 2024
@silvanocerza silvanocerza self-assigned this Feb 15, 2024
@silvanocerza silvanocerza requested a review from a team as a code owner February 15, 2024 10:38
@silvanocerza silvanocerza requested review from masci and shadeMe and removed request for a team and masci February 15, 2024 10:38
@github-actions github-actions bot added topic:tests 2.x Related to Haystack v2.0 type:documentation Improvements on the docs labels Feb 15, 2024
@coveralls
Copy link
Collaborator

coveralls commented Feb 15, 2024

Pull Request Test Coverage Report for Build 7918003446

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 20 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 89.172%

Files with Coverage Reduction New Missed Lines %
components/eval/statistical_evaluator.py 3 95.0%
components/eval/sas_evaluator.py 17 63.16%
Totals Coverage Status
Change from base Build 7904082418: 0.1%
Covered Lines: 4941
Relevant Lines: 5541

💛 - Coveralls

haystack/components/eval/statistical_evaluator.py Outdated Show resolved Hide resolved
haystack/components/eval/statistical_evaluator.py Outdated Show resolved Hide resolved
haystack/components/eval/statistical_evaluator.py Outdated Show resolved Hide resolved
haystack/components/eval/statistical_evaluator.py Outdated Show resolved Hide resolved
haystack/components/eval/statistical_evaluator.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@shadeMe shadeMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; just some minor changes. Feel free to merge once you're done.

haystack/components/eval/statistical_evaluator.py Outdated Show resolved Hide resolved
haystack/components/eval/statistical_evaluator.py Outdated Show resolved Hide resolved
haystack/components/eval/statistical_evaluator.py Outdated Show resolved Hide resolved
@silvanocerza silvanocerza merged commit 2b8a606 into main Feb 15, 2024
20 checks passed
@silvanocerza silvanocerza deleted the fix-statistical-evaluator branch February 15, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0 ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:tests type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants