Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Pipeline.draw() failing cause of missing socket #6965

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

silvanocerza
Copy link
Contributor

@silvanocerza silvanocerza commented Feb 9, 2024

Proposed Changes:

Change _to_mermaid_image() so it doesn't call _prepare_for_drawing() as it's already called in _to_mermaid_text().

Calling _to_mermaid_text() right after _prepare_for_drawing() caused the call in _to_mermaid_text() to fail as _prepare_for_drawing() adds some sockets to better show the inputs and outputs of the Pipeline.

How did you test it?

I tested it manually and updated integration tests.

Notes for the reviewer

I ignored the release notes as this bug has been introduced some minutes ago with #6961.

Checklist

@silvanocerza silvanocerza added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Feb 9, 2024
@silvanocerza silvanocerza self-assigned this Feb 9, 2024
@silvanocerza silvanocerza requested a review from a team as a code owner February 9, 2024 14:18
@silvanocerza silvanocerza requested review from vblagoje and removed request for a team February 9, 2024 14:18
@github-actions github-actions bot added topic:tests 2.x Related to Haystack v2.0 topic:core labels Feb 9, 2024
@coveralls
Copy link
Collaborator

coveralls commented Feb 9, 2024

Pull Request Test Coverage Report for Build 7845578623

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 88.613%

Totals Coverage Status
Change from base Build 7844859869: -0.002%
Covered Lines: 4786
Relevant Lines: 5401

💛 - Coveralls

@silvanocerza silvanocerza merged commit 21488ac into main Feb 9, 2024
22 checks passed
@silvanocerza silvanocerza deleted the fix-drawing branch February 9, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0 ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:core topic:tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants