Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enhance Pipeline.draw() to show image directly in Jupyter notebook #6961

Merged
merged 5 commits into from
Feb 9, 2024
Merged

feat: Enhance Pipeline.draw() to show image directly in Jupyter notebook #6961

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1c64b80
Enhance Pipeline.draw() to show image directly in Jupyter notebook
silvanocerza Feb 8, 2024
6290a18
Add util method to check if we're in a Jupyter notebook
silvanocerza Feb 9, 2024
b98b4e7
Split Pipeline.draw() in two methods
silvanocerza Feb 9, 2024
21fa35b
Update tests
silvanocerza Feb 9, 2024
a7a0309
Update releasenotes
silvanocerza Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update releasenotes
  • Loading branch information
@silvanocerza
silvanocerza committed Feb 9, 2024
commit a7a03090a7b1fa3a3e9bbe6495dbbb3148bab1d2
7 changes: 4 additions & 3 deletions releasenotes/notes/enhance-pipeline-draw-5fe3131db71f6f54.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
---
enhancements:
- |
`Pipeline.draw()` will now show the generated image inline if run in a Jupyter notebook.
It can also be called without a path to save the image if in a notebook. In all other cases
it will raise a `ValueError`.
Add new `Pipeline.show()` method to generated image inline if run in a Jupyter notebook.
If called outside a notebook it will raise a `PipelineDrawingError`.
`Pipeline.draw()` has also been simplified and the `engine` argument has been removed.
Now all images will be generated using Mermaid.