Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DocumentStore for Open Distro Elasticsearch #676

Merged
merged 5 commits into from
Dec 15, 2020

Conversation

tanaysoni
Copy link
Contributor

@tanaysoni tanaysoni commented Dec 10, 2020

The PR adds a new document store for the Open Distro Elasticsearch.

In addition to the filtering & query functionality of the ElasticsearchDocumentStore, the new document store provides efficient vector similarity implementation for large indices using the KNN plugin.

Resolves #665

@tanaysoni tanaysoni changed the title WIP: Add DocumentStore for Open Distro Elasticsearch Add DocumentStore for Open Distro Elasticsearch Dec 10, 2020
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. One potential change needed for scaling the scores...

haystack/document_store/elasticsearch.py Show resolved Hide resolved
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tanaysoni tanaysoni merged commit 369e237 into master Dec 15, 2020
@tanaysoni tanaysoni deleted the open-distro-elasticsearch branch December 15, 2020 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vector Similarity for AWS Elasticsearch
2 participants