Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix Pipeline test error #6741

Merged
merged 1 commit into from
Jan 15, 2024
Merged

fix: fix Pipeline test error #6741

merged 1 commit into from
Jan 15, 2024

Conversation

anakin87
Copy link
Member

Related Issues

Proposed Changes:

make tests pass

How did you test it?

local tests, CI

Checklist

@anakin87 anakin87 added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Jan 15, 2024
@anakin87 anakin87 requested a review from a team as a code owner January 15, 2024 11:49
@anakin87 anakin87 requested review from silvanocerza and removed request for a team January 15, 2024 11:49
@github-actions github-actions bot added topic:tests 2.x Related to Haystack v2.0 labels Jan 15, 2024
sjrl
sjrl approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@sjrl sjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix on this!

@anakin87 anakin87 merged commit 8eba053 into main Jan 15, 2024
21 checks passed
@anakin87 anakin87 deleted the fix-pipeline-test-error branch January 15, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjrl sjrl sjrl approved these changes

@silvanocerza silvanocerza Awaiting requested review from silvanocerza silvanocerza is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
2.x Related to Haystack v2.0 ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anakin87 @sjrl