Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Highlight optional connections in Pipeline.draw() #6724

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Jan 11, 2024

Related Issues

Proposed Changes:

Modify the output of Pipeline.draw() to:

  • add a (opt.) suffix to optional connections.
  • in Mermaid, make the relative arrow dotted instead of solid.

Example before:

fixed_decision_pipeline

Example after:

fixed_decision_pipeline

How did you test it?

Manual testing

Notes for the reviewer

n/a

Checklist

@github-actions github-actions bot added 2.x Related to Haystack v2.0 topic:core labels Jan 11, 2024
@ZanSara ZanSara marked this pull request as ready for review January 11, 2024 10:33
@ZanSara ZanSara requested review from a team as code owners January 11, 2024 10:33
@ZanSara ZanSara requested review from dfokina and masci and removed request for a team January 11, 2024 10:33
@ZanSara ZanSara self-assigned this Jan 11, 2024
@masci masci merged commit 24afc2a into main Jan 15, 2024
12 checks passed
@masci masci deleted the highlight-optional-conns-in-draw branch January 15, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0 topic:core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants