Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: pin openai>=1.1.0 #6657

Merged
merged 1 commit into from
Dec 28, 2023
Merged

build: pin openai>=1.1.0 #6657

merged 1 commit into from
Dec 28, 2023

Conversation

anakin87
Copy link
Member

Related Issues

Proposed Changes:

  • pin openai>=1.1.0
  • this prevents people who already have openai<1 installed from running pip install haystack-ai and getting incompatibility bugs

How did you test it?

Local test with openai==1.1.0

Checklist

@anakin87 anakin87 requested a review from a team as a code owner December 28, 2023 15:45
@anakin87 anakin87 requested review from julian-risch and removed request for a team December 28, 2023 15:45
@anakin87 anakin87 added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Dec 28, 2023
@github-actions github-actions bot added topic:build/distribution 2.x Related to Haystack v2.0 labels Dec 28, 2023
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Just keep in mind that we'll need another Haystack release for having an effect on pip install haystack-ai.

@anakin87 anakin87 merged commit 474cf44 into main Dec 28, 2023
8 of 9 checks passed
@anakin87 anakin87 deleted the pin-openai-gt-1 branch December 28, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0 ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:build/distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants