refactor: optimize API keys reading #6655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic:tests
2.x
anakin87
commented
Dec 28, 2023
| "Set the AZURE_AI_API_KEY environment variable (recommended) or pass it explicitly." | ||
| ) from e | ||
|
|
||
| self.api_key = api_key |
There was a problem hiding this comment.
I found out that the parameter self.api_key was never used, so I removed it.
anakin87
commented
Dec 28, 2023
| @@ -10,7 +10,7 @@ | |||
| class TestAzureOCRDocumentConverter: | |||
| def test_init_fail_wo_api_key(self, monkeypatch): | |||
| monkeypatch.delenv("AZURE_AI_API_KEY", raising=False) | |||
| with pytest.raises(ValueError, match="AzureOCRDocumentConverter expects an Azure Credential key"): | |||
| with pytest.raises(ValueError): | |||
There was a problem hiding this comment.
The error message changed, but I think we don't want to rely on error messages anymore.
So I only check the error type.
anakin87
added
the
ignore-for-release-notes
masci
reviewed
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
I improved the API keys reading logic and adopted it in all components that need it.
How did you test it?
Local tests, CI
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.