Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: rename all remaining metadata to meta #6650

Merged
merged 2 commits into from
Dec 28, 2023

Conversation

anakin87
Copy link
Member

Related Issues

Proposed Changes:

  • change metadata to meta
  • (in some cases, I may gone a little too far with the renaming, but probably it's not a problem)

How did you test it?

CI

Checklist

@github-actions github-actions bot added topic:tests 2.x Related to Haystack v2.0 type:documentation Improvements on the docs labels Dec 27, 2023
@anakin87 anakin87 marked this pull request as ready for review December 27, 2023 16:40
@anakin87 anakin87 requested review from a team as code owners December 27, 2023 16:40
@anakin87 anakin87 requested review from dfokina, masci and julian-risch and removed request for a team and masci December 27, 2023 16:40
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Better make changes like this as soon as possible rather than later. Our new tutorials don't use meta so they are not affected. Advent challenges I haven't checked. I could well imagine that there are some docs pages with code snippets that need to be updated. Could you please sync with @dfokina on this? Thank you!

@anakin87
Copy link
Member Author

Thanks, @julian-risch.

I'm syncing with Daria and Devrel. Luckily, Advent challenges are not affected.

@anakin87 anakin87 merged commit c773c30 into main Dec 28, 2023
40 checks passed
@anakin87 anakin87 deleted the change-metadata-to-meta branch December 28, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0 topic:tests type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants