Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support single metadata dictionary in MarkdownToDocument #6629

Merged
merged 9 commits into from
Jan 9, 2024
Merged

feat: support single metadata dictionary in MarkdownToDocument #6629

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
be931f7
support single metadata dict in markdown2document
ZanSara Dec 22, 2023
348999c
reno
ZanSara Dec 22, 2023
c1cf58b
Merge branch 'main' into single-meta-in-markdown2document
ZanSara Dec 22, 2023
e904221
unwrap list
ZanSara Dec 22, 2023
69dd41e
direct key access
ZanSara Dec 22, 2023
0387267
Merge branch 'main' into single-meta-in-markdown2document
ZanSara Dec 22, 2023
49e6ae8
typing
ZanSara Dec 22, 2023
32207ed
Merge branch 'main' into single-meta-in-markdown2document
ZanSara Jan 8, 2024
9e60141
add explicit test
ZanSara Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
unwrap list
  • Loading branch information
@ZanSara
ZanSara committed Dec 22, 2023
commit e9042217115ad6371716121a0eaac049f40c829d
2 changes: 1 addition & 1 deletion test/components/converters/test_markdown_to_document.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def test_run_with_meta(self, test_files_path):

with patch("haystack.components.converters.markdown.MarkdownIt"):
output = converter.run(
sources=[bytestream, test_files_path / "markdown" / "sample.md"], meta=[{"language": "it"}]
sources=[bytestream, test_files_path / "markdown" / "sample.md"], meta={"language": "it"}
)

# check that the metadata from the bytestream is merged with that from the meta parameter
Expand Down
Loading