feat: support single metadata dictionary in PyPDFToDocument
#6615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julian-risch
requested changes
Dec 21, 2023
There was a problem hiding this comment.
Looks quite good to me already. Two change requests: Could you please update the usage example here to use meta data. And could you please make sure that we test both meta input formats in the tests: single dict and list of multiple dicts and one run without any meta data? Right now, the names of the tests can also be improved. We have "test_run" and "test_run_with_meta" but both use meta.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
metain FileTypeRouter #6392Proposed Changes:
Adds support for single metadata dictionary input in
PyPDFToDocument. In this way, additional metadata can be added to all files processed by this component even when the length of the list of sources is unknown.How did you test it?
Added tests and run locally.
Notes for the reviewer
See the linked issue and this discussion for context.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.