Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: simplify the management of test dependencies #6559

Merged
merged 4 commits into from
Dec 15, 2023
Merged

chore: simplify the management of test dependencies #6559

merged 4 commits into from
Dec 15, 2023

Conversation

anakin87
Copy link
Member

Proposed Changes:

  • keep track of the dependencies needed to run tests in a unique requirements file
  • remove audio dependency group (consistently with 2.x approach)

How did you test it?

CI

Checklist

@anakin87 anakin87 added ignore-for-release-notes PRs with this flag won't be included in the release notes. and removed topic:tests topic:build/distribution topic:CI 2.x Related to Haystack v2.0 labels Dec 15, 2023
@anakin87 anakin87 marked this pull request as ready for review December 15, 2023 12:19
@anakin87 anakin87 requested a review from a team as a code owner December 15, 2023 12:19
@anakin87 anakin87 requested review from masci and removed request for a team December 15, 2023 12:19
@vblagoje
Copy link
Member

Thanks for this work @anakin87 🚀

vblagoje
vblagoje approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@vblagoje vblagoje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's perhaps wait for Massi as well

masci
masci reviewed Dec 15, 2023
View reviewed changes
.github/workflows/e2e.yml Outdated Show resolved Hide resolved
@anakin87 anakin87 merged commit cf47abd into main Dec 15, 2023
11 checks passed
@anakin87 anakin87 deleted the simplify-management-test-dependencies branch December 15, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masci masci masci left review comments

@vblagoje vblagoje vblagoje approved these changes

Assignees
No one assigned
Labels
2.x Related to Haystack v2.0 ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:build/distribution topic:CI topic:tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anakin87 @vblagoje @masci