Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: rename TextDocumentSplitter to DocumentSplitter #6223

Merged
merged 3 commits into from
Nov 3, 2023
Merged

refactor!: rename TextDocumentSplitter to DocumentSplitter #6223

merged 3 commits into from
Nov 3, 2023

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Nov 2, 2023

Related Issues

Proposed Changes:

  • rename TextDocumentSplitter to DocumentSplitter, to allow a better distinction between Components that operate on text and those that operate on Documents.
  • also rename the python files

How did you test it?

CI

Checklist

@anakin87 anakin87 marked this pull request as ready for review November 2, 2023 16:05
@anakin87 anakin87 requested review from a team as code owners November 2, 2023 16:05
@anakin87 anakin87 requested review from dfokina, silvanocerza and vblagoje and removed request for a team November 2, 2023 16:05
@coveralls
Copy link
Collaborator

coveralls commented Nov 2, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6735199962

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 40.873%
Totals Coverage Status
Change from base Build 6733996428: 0.0%
Covered Lines: 10497
Relevant Lines: 25682
💛 - Coveralls

vblagoje
vblagoje approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@vblagoje vblagoje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anakin87 anakin87 merged commit 063d27c into main Nov 3, 2023
137 checks passed
@anakin87 anakin87 deleted the rename-preprocessors branch November 3, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vblagoje vblagoje vblagoje approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

@silvanocerza silvanocerza Awaiting requested review from silvanocerza silvanocerza is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
2.x Related to Haystack v2.0 topic:build/distribution topic:dependencies topic:tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename TextDocumentSplitter to DocumentSplitter in 2.0
3 participants
@anakin87 @coveralls @vblagoje