Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make __init__.py files uniform in preview #6187

Merged
merged 2 commits into from
Oct 30, 2023
Merged

chore: make __init__.py files uniform in preview #6187

merged 2 commits into from
Oct 30, 2023

Conversation

anakin87
Copy link
Member

Related Issues

Some of these files are missing and some others don't follow the common format

Proposed Changes:

Fixed this

How did you test it?

CI

Checklist

@anakin87 anakin87 added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Oct 27, 2023
@anakin87 anakin87 requested a review from a team as a code owner October 27, 2023 16:58
@anakin87 anakin87 requested review from silvanocerza and removed request for a team October 27, 2023 16:58
@github-actions github-actions bot added the 2.x Related to Haystack v2.0 label Oct 27, 2023
@anakin87 anakin87 changed the title chore: make __init__.py files uniform in the preview chore: make __init__.py files uniform in preview Oct 27, 2023
@masci masci self-requested a review October 27, 2023 17:04
masci
masci suggested changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix the tests but LGTM

@anakin87 anakin87 requested a review from masci October 27, 2023 17:45
masci
masci approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@anakin87 anakin87 merged commit 1a64fc5 into main Oct 30, 2023
20 checks passed
@anakin87 anakin87 deleted the fix-preview-init branch October 30, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masci masci masci approved these changes

@silvanocerza silvanocerza Awaiting requested review from silvanocerza silvanocerza is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
2.x Related to Haystack v2.0 ignore-for-release-notes PRs with this flag won't be included in the release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anakin87 @masci