Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Simplify Python code with ruff rules SIM #5833

Merged
merged 5 commits into from
Sep 20, 2023
Merged

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Sep 16, 2023

Related Issues

  • fixes #issue-number

Proposed Changes:

https://docs.astral.sh/ruff/rules/#flake8-simplify-sim

How did you test it?

Notes for the reviewer

Checklist

@coveralls
Copy link
Collaborator

coveralls commented Sep 16, 2023

Pull Request Test Coverage Report for Build 6238576691

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1222 unchanged lines in 30 files lost coverage.
  • Overall coverage increased (+0.06%) to 49.112%

Files with Coverage Reduction New Missed Lines %
schema.py 1 68.62%
utils/context_matching.py 1 95.7%
nodes/connector/crawler.py 2 37.85%
nodes/other/route_documents.py 4 86.84%
nodes/reader/farm.py 4 40.0%
nodes/file_converter/txt.py 5 86.49%
document_stores/search_engine.py 6 62.66%
modeling/evaluation/eval.py 7 18.75%
document_stores/es_converter.py 8 22.0%
document_stores/elasticsearch/es8.py 9 44.55%
Totals Coverage Status
Change from base Build 6236698909: 0.06%
Covered Lines: 11834
Relevant Lines: 24096

💛 - Coveralls

@masci masci added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Sep 18, 2023
@masci masci merged commit bf6d306 into deepset-ai:main Sep 20, 2023
75 checks passed
@cclauss cclauss deleted the Simplify branch September 20, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants