Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix the test_nin_filter_embedding() function #5829

Merged
merged 2 commits into from
Sep 16, 2023

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Sep 15, 2023

Related Issues

  • fixes #issue-number

Proposed Changes:

This function has been bugging me because mypy, pylint, and two different sets of ruff rules did not like it. To me it seemed like doc was an undefined name in the contest of the or. It finally strikes me that the or should be an if.

How did you test it?

Notes for the reviewer

Checklist

@cclauss cclauss requested a review from a team as a code owner September 15, 2023 21:11
@cclauss cclauss requested review from masci and removed request for a team September 15, 2023 21:11
@cclauss cclauss changed the title Fix the test_nin_filter_embedding() function test: Fix the test_nin_filter_embedding() function Sep 15, 2023
@coveralls
Copy link
Collaborator

coveralls commented Sep 15, 2023

Pull Request Test Coverage Report for Build 6203000065

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 49.058%

Totals Coverage Status
Change from base Build 6200529453: 0.004%
Covered Lines: 11845
Relevant Lines: 24145

💛 - Coveralls

@masci masci added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Sep 16, 2023
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@masci masci merged commit 66b8b66 into deepset-ai:main Sep 16, 2023
63 of 64 checks passed
@cclauss cclauss deleted the fix-test_nin_filter_embedding branch September 16, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants