Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fix all ruff pyflakes errors except unused imports #5820

Merged
merged 3 commits into from
Sep 15, 2023
Merged

ci: Fix all ruff pyflakes errors except unused imports #5820

merged 3 commits into from
Sep 15, 2023

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Sep 14, 2023 •
edited
Loading

Related Issues

  • fixes #issue-number

Proposed Changes:

Fix the pyflakes errors in ruff --select=F541,F811,F821,F841 . leaving only F401 (unused imports).

We will save the 333 instances of F401 unused-import for a separate PR because imports may have side-effects.

How did you test it?

% pre-commit run ruff --all-files
% pre-commit run --all-files

Notes for the reviewer

Checklist

@cclauss cclauss requested review from a team as code owners September 14, 2023 17:09
@cclauss cclauss requested review from dfokina and MichelBartels and removed request for a team September 14, 2023 17:09
@coveralls
Copy link
Collaborator

coveralls commented Sep 14, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6200024361

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 49.056%
Totals Coverage Status
Change from base Build 6199684027: 0.02%
Covered Lines: 11844
Relevant Lines: 24144
💛 - Coveralls

@masci masci added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Sep 15, 2023
masci
masci suggested changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the release note file and we can merge!

releasenotes/notes/fix-some-pyflakes-errors-69a1106efa5d0203.yaml Outdated Show resolved Hide resolved
@github-actions github-actions bot added the type:documentation Improvements on the docs label Sep 15, 2023
@masci masci merged commit 1bc03dd into deepset-ai:main Sep 15, 2023
72 checks passed
@cclauss cclauss deleted the fix-some-pyflakes-errors branch September 15, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masci masci masci approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina was automatically assigned from deepset-ai/documentation

@MichelBartels MichelBartels Awaiting requested review from MichelBartels MichelBartels is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:build/distribution topic:dependencies topic:document_store topic:faiss topic:file_converter topic:modeling topic:pinecone topic:pipeline topic:preprocessing topic:promptnode topic:reader topic:rest_api topic:tests topic:weaviate type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cclauss @coveralls @masci