Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Python performance improvements with ruff C4 and PERF fixes #5803

Merged
merged 6 commits into from
Sep 16, 2023
Merged

perf: Python performance improvements with ruff C4 and PERF fixes #5803

merged 6 commits into from
Sep 16, 2023

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Sep 13, 2023 •
edited
Loading

Related Issues

  • fixes #issue-number

Proposed Changes:

Make minor performance improvements to Python code with:
% ruff --select=C4,PERF --fix .

Is there a way to run before vs. after benchmarks?

How did you test it?

Notes for the reviewer

Checklist

@cclauss cclauss requested a review from a team as a code owner September 13, 2023 18:00
@cclauss cclauss requested review from masci and removed request for a team September 13, 2023 18:00
@coveralls
Copy link
Collaborator

coveralls commented Sep 13, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6206023869

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 45 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.002%) to 49.056%
Files with Coverage Reduction New Missed Lines %
nodes/file_converter/base.py 1 72.73%
nodes/retriever/sparse.py 44 48.21%
Totals Coverage Status
Change from base Build 6200529453: 0.002%
Covered Lines: 11844
Relevant Lines: 24144
💛 - Coveralls

@masci masci added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Sep 14, 2023
masci
masci suggested changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor formatting issue, otherwise LGTM. Looking into the test failures now, it looks like a problem related to running from a fork.

pyproject.toml Outdated Show resolved Hide resolved
@masci
Copy link
Contributor

masci commented Sep 14, 2023

Need another fix for the example tests but if you resolve the conflict this is good to go

@cclauss cclauss marked this pull request as draft September 14, 2023 15:35
@github-actions github-actions bot added topic:DX Developer Experience and removed topic:images topic:CI labels Sep 15, 2023
@cclauss cclauss marked this pull request as ready for review September 15, 2023 20:23
@cclauss cclauss requested a review from a team as a code owner September 15, 2023 20:23
@cclauss cclauss requested review from dfokina and removed request for a team September 15, 2023 20:23
@masci masci merged commit 91ab90a into deepset-ai:main Sep 16, 2023
74 checks passed
@cclauss cclauss deleted the ruff_C4_and_PERF branch September 16, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masci masci masci approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina was automatically assigned from deepset-ai/documentation

Assignees
No one assigned
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:build/distribution topic:dependencies topic:document_store topic:DX Developer Experience topic:elasticsearch topic:file_converter topic:modeling topic:opensearch topic:pipeline topic:preprocessing topic:promptnode topic:reader topic:retriever topic:tests type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cclauss @coveralls @masci