Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update description of crawler_depth param #5610

Merged
merged 1 commit into from
Aug 29, 2023
Merged

docs: update description of crawler_depth param #5610

merged 1 commit into from
Aug 29, 2023

Conversation

dfokina
Copy link
Contributor

@dfokina dfokina commented Aug 22, 2023

Related Issues

Proposed Changes:

  • Updating docstrings to explain that crawler_depth can be values >1.

How did you test it?

Notes for the reviewer

Checklist

@dfokina dfokina requested a review from a team as a code owner August 22, 2023 10:56
@dfokina dfokina requested review from MichelBartels and removed request for a team August 22, 2023 10:56
@dfokina dfokina added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Aug 22, 2023
@github-actions github-actions bot added topic:crawler type:documentation Improvements on the docs labels Aug 22, 2023
MichelBartels
MichelBartels approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@MichelBartels MichelBartels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@dfokina dfokina merged commit fbc1951 into main Aug 29, 2023
24 of 26 checks passed
@dfokina dfokina deleted the upd-crawler-depth-param branch August 29, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichelBartels MichelBartels MichelBartels approved these changes

Assignees
No one assigned
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:crawler type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Update Crawler docs
2 participants
@dfokina @MichelBartels