chore: add citation #4573
Merged
chore: add citation #4573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayankjobanputra
added
the
ignore-for-release-notes
mayankjobanputra
requested review from
silvanocerza,
masci,
tholor,
julian-risch and
TuanaCelik
and removed request for
a team
|
@masci @tholor @julian-risch There are a few things that need to be decided:
|
tholor
reviewed
Apr 3, 2023
julian-risch
requested changes
Apr 3, 2023
There was a problem hiding this comment.
Hi @mayankjobanputra Good suggestion! I'd prefer a bolder title: "Haystack: the end-to-end NLP framework for pragmatic builders". For author names, Malte already made a good suggestion.
julian-risch
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
How did you test it?
No need to add
Notes for the reviewer
Need to decide on the title and authors
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.