build: Remove xpdf dependencies #4314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
approved these changes
Mar 2, 2023
DavidGerva
added a commit
to DavidGerva/haystack-tutorials
that referenced
this pull request
Mar 3, 2023
- no more needed as per deepset-ai/haystack#4314
bilgeyucel
pushed a commit
to deepset-ai/haystack-tutorials
that referenced
this pull request
Mar 7, 2023
* Remove xpdf dependency from tutorial 8 and 16 - no more needed as per deepset-ai/haystack#4314 * Also add pdf in haystack installation needed for PDFToTextConverter
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Since #4226 is merged, Haystack doesn't depend anymore on
xpdf. This PR removes allxpdfdependencies in our Dockerfiles and in the tests and adds thepdfextra to our base image.How did you test it?
I built the Docker images locally and ran the file-upload endpoint of our REST API.
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.