Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix all EOF #3852

Merged
merged 10 commits into from
Jan 16, 2023
Merged

chore: fix all EOF #3852

merged 10 commits into from
Jan 16, 2023

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Jan 12, 2023 •
edited
Loading

Related Issues

Proposed Changes:

  • Run pre-commit run --all triggers the EOF fixer on a lot of files.
  • Occasionally, one needs to run the pre-commit hooks after having commited without them. Right now such operation is impossible because of EOF triggering on a ton of unrelated files.
  • This PR adds the EOF fixes so that we can safely run pre-commit run --all when needed.

How did you test it?

n/a

Notes for the reviewer

Don't be shocked by the terrifying diff 😄 This PR adds only EOF fixes, plus trailing whitespace trimming also introduced by the hooks. No other manual changes were added.

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added tests that demonstrate the correct behavior of the change
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@ZanSara ZanSara added type:refactor Not necessarily visible to the users ignore-for-release-notes PRs with this flag won't be included in the release notes. labels Jan 12, 2023
@ZanSara ZanSara requested a review from a team as a code owner January 12, 2023 11:18
@ZanSara ZanSara requested review from mayankjobanputra and removed request for a team January 12, 2023 11:18
@ZanSara ZanSara removed the proposal label Jan 12, 2023
@ZanSara ZanSara requested review from masci and removed request for mayankjobanputra January 12, 2023 11:22
@ZanSara ZanSara marked this pull request as draft January 12, 2023 18:39
@ZanSara ZanSara removed the proposal label Jan 13, 2023
@ZanSara ZanSara removed the proposal label Jan 13, 2023
@ZanSara ZanSara marked this pull request as ready for review January 16, 2023 10:26
@ZanSara ZanSara removed the proposal label Jan 16, 2023
masci
masci approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ZanSara ZanSara merged commit 3ffdb0a into main Jan 16, 2023
@ZanSara ZanSara deleted the fix-end-of-file-hook-cleanup branch January 16, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masci masci masci approved these changes

Assignees
No one assigned
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. type:refactor Not necessarily visible to the users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ZanSara @masci