refactor: improve monkey patch for SklearnQueryClassifier
#3732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@julian-risch feel free to jump in! |
julian-risch
approved these changes
Dec 20, 2022
There was a problem hiding this comment.
The changes look good to me. 👍 Thank you @anakin87 ! I just replaced the old models on S3 with the new ones. The test case test_query_keyword_statement_classifier in test_standard_pipelines.py still passes. I will merge this PR now.
ZanSara
pushed a commit
that referenced
this pull request
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
SklearnQueryClassifier#3678Proposed Changes:
As described in #2904 (comment), this extended monkey patch is needed to make the new models (trained with
scikit-learn==1.2.0) compatible withscikit-learn>=1.0.0How did you test it?
Manual verification
Checklist