Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the query_batch method of the deepsetcloud document store - … #3724

Merged
merged 5 commits into from
Dec 19, 2022

Conversation

zoltan-fedor
Copy link
Contributor

Related Issues

Proposed Changes:

This is an easy fix of a simple code syntax issue - wrong indentation causing logical error in the code of the deepsetcloud document store's query_batch() method.

How did you test it?

All tests were passing before, so this is tested by code logic only.

Notes for the reviewer

N/A

Checklist

@zoltan-fedor zoltan-fedor requested a review from a team as a code owner December 16, 2022 00:09
@zoltan-fedor zoltan-fedor requested review from vblagoje and removed request for a team December 16, 2022 00:09
Copy link
Member

@tstadel tstadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @zoltan-fedor thx for the fix!

@sjrl
Copy link
Contributor

sjrl commented Dec 16, 2022

Hey @zoltan-fedor I think you need to update your branch with the current main to get the build to pass. It looks like your branch is ~265 commits behind the current main branch of Haystack.

@tstadel
Copy link
Member

tstadel commented Dec 16, 2022

Hey @zoltan-fedor I think you need to update your branch with the current main to get the build to pass. It looks like your branch is ~265 commits behind the current main branch of Haystack.

@zoltan-fedor I updated the branch for you. Hope, that's ok :-)

@tstadel tstadel added type:bug Something isn't working topic:dc-api labels Dec 16, 2022
@zoltan-fedor
Copy link
Contributor Author

Hey @tstadel , @sjrl
Thanks for fixing this.
I was working on two different PRs in parallel and I must have forked this branch from the wrong base branch.
I was wondering why some of the base CI steps were failing with no numpy... :-)

@ZanSara ZanSara requested review from ZanSara and removed request for vblagoje December 19, 2022 08:56
Copy link
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix! 🙌

@ZanSara ZanSara merged commit 3990697 into deepset-ai:main Dec 19, 2022
@zoltan-fedor zoltan-fedor deleted the bugfix-deepsetcloud-query-batch branch December 19, 2022 16:31
bogdankostic pushed a commit that referenced this pull request Dec 22, 2022
#3724)

* Fixing the `query_batch` method of the deepsetcloud document store - fixes #3722

* Trigger Build

* Trigger Build

* Trigger CI

Co-authored-by: Thomas Stadelmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code error in the deepsetcloud document store
4 participants