Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the proposals process #3718

Merged
merged 5 commits into from
Dec 19, 2022
Merged

Update the proposals process #3718

merged 5 commits into from
Dec 19, 2022

Conversation

masci
Copy link
Contributor

@masci masci commented Dec 15, 2022

Proposed Changes:

  • Clarify the process and the people involved in the process.
  • Add a Github workflow to manage stale proposals

@masci masci added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Dec 15, 2022
@masci masci requested a review from a team as a code owner December 15, 2022 10:20
@masci masci requested review from julian-risch and removed request for a team December 15, 2022 10:20
@mayankjobanputra
Copy link
Contributor

@masci LGTM.

I have maybe one question regarding changes that require a proposal:

  1. What about decisions like setting flags (i.e., TORCH_FORCE_WEIGHTS_ONLY_LOAD = True) by default for Haystack? Do we need proposals for such decisions?

Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I especially like that it's crystal clear now when the "final comment" period starts.
One small detail, where we could be more clear is in the phrase "we add a comment and a label to your PR.". We could write down explicitly who is "we" here. It should be the decision driver in my opinion. An alternative would be the third core contributor who approves the proposal but that's easier to miss.

@masci masci merged commit 8edfd89 into main Dec 19, 2022
@masci masci deleted the massi/proposals branch December 19, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants