fix: pin espnet in the audio extra
#3693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZanSara
requested review from
mayankjobanputra
and removed request for
a team
ZanSara
changed the title
audio extraespnet in the audio extra
ZanSara
requested review from
julian-risch
and removed request for
mayankjobanputra
julian-risch
approved these changes
Dec 12, 2022
There was a problem hiding this comment.
Looks good to me as a quick fix! 👍 I am pretty sure the previous espnet version v.202207 also works with Haystack so we could be a bit less strict with the pinning. For a quick fix it's good as is.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
espnetto202209to keep the tests green.How did you test it?
Notes for the reviewer
n/a
Checklist
I added tests that demonstrate the correct behavior of the changeI documented my code