Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix PreProcessor split_by schema #3680

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Dec 7, 2022

Related Issues

Proposed Changes:

  • Fix typing of the split_by parameter in all methods

How did you test it?

  • Regenerated the schema by hand, which yielded:
"split_by": {
  "title": "Split By",
  "default": "word",
  "enum": [
    "word",
    "sentence",
    "passage"
  ],
  "anyOf": [
    {
      "type": "string"
    },
    {
      "type": "null"
    }
  ]
},

while, for comparison, the current schema looks like:

"split_by": {
  "default": "word",
  "enum": [
    "word",
    "sentence",
    "passage"
  ],
  "title": "Split By",
  "type": "string"
},

Notes for the reviewer

n/a

Checklist

@ZanSara ZanSara marked this pull request as ready for review December 7, 2022 15:19
@ZanSara ZanSara requested a review from a team as a code owner December 7, 2022 15:19
@ZanSara ZanSara requested review from bogdankostic and removed request for a team December 7, 2022 15:19
Copy link
Contributor

@bogdankostic bogdankostic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZanSara ZanSara merged commit 642fa3a into main Dec 12, 2022
@ZanSara ZanSara deleted the fix-split-by-null-schema branch December 12, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PreProcessor from json config {'split_by': null} gives schema validation problem
2 participants