Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove test extra #3679

Merged
merged 3 commits into from
Dec 12, 2022
Merged

refactor: remove test extra #3679

merged 3 commits into from
Dec 12, 2022

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Dec 7, 2022 •
edited
Loading

Related Issues

Proposed Changes:

  • Remove the test extra
  • Adjust all extras accordingly

How did you test it?

  • Local install
  • CI

Notes for the reviewer

n/a

Checklist

@ZanSara ZanSara added type:refactor Not necessarily visible to the users topic:dependencies topic:DX Developer Experience labels Dec 7, 2022
@ZanSara ZanSara marked this pull request as ready for review December 7, 2022 14:54
@ZanSara ZanSara requested a review from a team as a code owner December 7, 2022 14:54
@ZanSara ZanSara requested review from masci and removed request for a team December 7, 2022 14:54
masci
masci approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@ZanSara ZanSara merged commit b1fc912 into main Dec 12, 2022
@ZanSara ZanSara deleted the remove-test-extra branch December 12, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masci masci masci approved these changes

Assignees
No one assigned
Labels
topic:dependencies topic:DX Developer Experience type:refactor Not necessarily visible to the users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Install tests with 'dev' installation
2 participants
@ZanSara @masci