Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert Weaviate query with filters and improve tests #3646

Merged
merged 6 commits into from
Dec 6, 2022

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Nov 30, 2022

Related Issues

Proposed Changes:

How did you test it?

  • Locally, CI

Notes for the reviewer

See the great analysis of the issue by @zoltan-fedor #3628 (comment) and vote for this issue on Weaviate: weaviate/weaviate#2393

Checklist

@ZanSara ZanSara marked this pull request as ready for review November 30, 2022 17:28
@ZanSara ZanSara requested a review from a team as a code owner November 30, 2022 17:28
@ZanSara ZanSara requested review from julian-risch and masci and removed request for a team and julian-risch November 30, 2022 17:28
.github/workflows/tests.yml Outdated Show resolved Hide resolved
test/document_stores/test_weaviate.py Outdated Show resolved Hide resolved
@ZanSara ZanSara requested a review from masci December 6, 2022 08:29
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZanSara ZanSara merged commit fc89f6e into main Dec 6, 2022
@ZanSara ZanSara deleted the revert-weaviate-query-filters branch December 6, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants